Skip to content

feat(NumberTheory/Height/NumberField): the absolute height of an algebraic number#41605

Open
tb65536 wants to merge 2 commits into
leanprover-community:masterfrom
tb65536:tb_extn8
Open

feat(NumberTheory/Height/NumberField): the absolute height of an algebraic number#41605
tb65536 wants to merge 2 commits into
leanprover-community:masterfrom
tb65536:tb_extn8

Conversation

@tb65536

@tb65536 tb65536 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

This PR defines the absolute height of an algebraic number. The proof that this definition does not depend on the choice of ambient number field is in #41606, but it would be nice to have this definition in mathlib earlier for statements in a downstream repo.


Open in Gitpod

@tb65536 tb65536 added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-number-theory Number theory (also use t-algebra or t-analysis to specialize) t-algebra Algebra (groups, rings, fields, etc) labels Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

PR summary f75c115ba1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ absMulHeight₁

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit f75c115).

  • +1 new declarations
  • −0 removed declarations
+NumberField.absMulHeight₁

No changes to strong technical debt.

No changes to weak technical debt.

Current commit f75c115ba1
Reference commit a33a5ccd63

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc) t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant